Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster: pass service_pricipal.client_secret during read #4339

Merged
merged 4 commits into from
Sep 17, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Sep 16, 2019

No description provided.

@katbyte katbyte added this to the v1.34.0 milestone Sep 16, 2019
@katbyte katbyte requested a review from a team September 16, 2019 21:05
@ghost ghost added the size/XS label Sep 16, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghost ghost added size/M and removed size/XS labels Sep 17, 2019
@katbyte katbyte merged commit 01c1ca9 into master Sep 17, 2019
@katbyte katbyte deleted the aks/pass_along_client_secret branch September 17, 2019 20:58
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@invidian
Copy link
Contributor

Looks like because of that now Terraform wants to re-create AKS clusters. Snippet from plan:

16:34:51        service_principal.0.client_secret:                      <sensitive> => <sensitive> (forces new resource)
16:34:51        tags.%:                                                 "1" => "1"

gambtho pushed a commit to gambtho/terraform-provider-azurerm that referenced this pull request Sep 18, 2019
@ghost
Copy link

ghost commented Oct 18, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants