-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AKS: Support outbound IPs when using standard loadbalancer #4472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this functionality urgently. Is there anything we can do to help out @tombuildsstuff? |
I'd also really like this. Here's the workaround I have in the meantime: data "azurerm_resource_group" "this" {
...
}
resource "azurerm_public_ip" "cluster" {
...
}
resource "azurerm_kubernetes_cluster" "this" {
...
# Temporary hack until https://github.com/terraform-providers/terraform-provider-azurerm/issues/4322 is fixed
provisioner "local-exec" {
interpreter = ["bash", "-c"]
command = <<EOF
if [ -z "$(az extension list | jq -r '.[] | select(.name == "aks-preview")')" ]; then
az extension add -n aks-preview -y
else
az extension update -n aks-preview || true
fi
az aks update \
--resource-group ${data.azurerm_resource_group.this.name} \
--name ${self.name} \
--load-balancer-outbound-ips ${azurerm_public_ip.cluster.id}
EOF
}
} |
Hi @tombuildsstuff , any chance we can have this feature merged any time soon? |
Hi @tombuildsstuff - is there anything we can do to help move this PR forward? |
@tombuildsstuff can we get this expedited for a release soon? We're having fun with duplicate ips on all our clusters that has Standard SKU. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
77ce448
to
37a5044
Compare
37a5044
to
1c778f9
Compare
Hello, |
@tombuildsstuff any idea on this? |
Hi @tombuildsstuff ! |
@landro unfortunately this isn't something we've got time to rebase at the moment - we're hoping that we can come back to this once the remaining bits of 2.0 have come together. From our side if someone has time to rebase/fix this up/send a new PR we're more than happy to close this PR in favour of another one - however I don't believe we're going to get a chance to do this in the next couple of weeks unfortunately. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Re-basing #4400 - originally by @evenh
Fixes #4322