Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS: Support outbound IPs when using standard loadbalancer #4472

Closed
wants to merge 1 commit into from

Conversation

tombuildsstuff
Copy link
Contributor

Re-basing #4400 - originally by @evenh

Fixes #4322

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fail:
image

@evenh
Copy link
Contributor

evenh commented Oct 10, 2019

We need this functionality urgently. Is there anything we can do to help out @tombuildsstuff?

@Bowbaq
Copy link
Contributor

Bowbaq commented Oct 10, 2019

I'd also really like this. Here's the workaround I have in the meantime:

data "azurerm_resource_group" "this" {
  ...
}

resource "azurerm_public_ip" "cluster" {
  ...
}

resource "azurerm_kubernetes_cluster" "this" {
  ...

  # Temporary hack until https://github.com/terraform-providers/terraform-provider-azurerm/issues/4322 is fixed
  provisioner "local-exec" {
    interpreter = ["bash", "-c"]
    command     = <<EOF
      if [ -z "$(az extension list | jq -r '.[] | select(.name == "aks-preview")')" ]; then
        az extension add -n aks-preview -y
      else
        az extension update -n aks-preview || true
      fi

      az aks update \
        --resource-group ${data.azurerm_resource_group.this.name} \
        --name ${self.name} \
        --load-balancer-outbound-ips ${azurerm_public_ip.cluster.id}
EOF
  }
}

@landro
Copy link

landro commented Oct 14, 2019

Hi @tombuildsstuff , any chance we can have this feature merged any time soon?

@landro
Copy link

landro commented Oct 24, 2019

Hi @tombuildsstuff - is there anything we can do to help move this PR forward?

@tombuildsstuff tombuildsstuff modified the milestones: v1.36.0, v1.37.0 Oct 28, 2019
@ekarlso
Copy link
Contributor

ekarlso commented Nov 1, 2019

@tombuildsstuff can we get this expedited for a release soon? We're having fun with duplicate ips on all our clusters that has Standard SKU.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff removed this from the v1.37.0 milestone Nov 21, 2019
@tombuildsstuff tombuildsstuff added this to the v1.38.0 milestone Nov 21, 2019
@seboss666
Copy link

Hello,
I've just ran into the problem of "duplicate IP" when switching to standard LB SKU (to activate API Server authorized IP ranges . Any update on conflict resolution ?

@tombuildsstuff tombuildsstuff modified the milestones: v1.38.0, v1.39.0 Nov 28, 2019
@ekarlso
Copy link
Contributor

ekarlso commented Dec 5, 2019

@tombuildsstuff any idea on this?

@tombuildsstuff tombuildsstuff modified the milestones: v1.39.0, v1.40.0 Dec 11, 2019
@tombuildsstuff tombuildsstuff modified the milestones: v1.40.0, v1.41.0 Dec 18, 2019
@landro
Copy link

landro commented Jan 10, 2020

Hi @tombuildsstuff !
this PR has been pushed from milestone to milestone for the past few months. Do you think it will make it this time? Is there anything we can do to help out?

@tombuildsstuff tombuildsstuff removed this from the v1.41.0 milestone Jan 10, 2020
@tombuildsstuff
Copy link
Contributor Author

@landro unfortunately this isn't something we've got time to rebase at the moment - we're hoping that we can come back to this once the remaining bits of 2.0 have come together.

From our side if someone has time to rebase/fix this up/send a new PR we're more than happy to close this PR in favour of another one - however I don't believe we're going to get a chance to do this in the next couple of weeks unfortunately.

@lamdor
Copy link
Contributor

lamdor commented Jan 15, 2020

just as an FYI, @evenh has rebased this into a new PR: #5394

@katbyte
Copy link
Collaborator

katbyte commented Jan 15, 2020

thanks @rubbish, closing in favour of #5394.

@katbyte katbyte closed this Jan 15, 2020
@tombuildsstuff tombuildsstuff deleted the outbound-IPs branch February 3, 2020 10:10
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AKS: support setting cluster outbound IPs when using standard loadbalancer
8 participants