Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default_site_hostname attribute #4479

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Adding default_site_hostname attribute #4479

merged 1 commit into from
Oct 2, 2019

Conversation

phillipsj
Copy link
Contributor

This fixes #4373 by adding the default_site_hostname attribute to the list of attributes.

This fixes #4373 by adding the default_site_hostname attribute to the list of attributes.
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @phillipsj

@tombuildsstuff tombuildsstuff added this to the v1.35.0 milestone Oct 2, 2019
@tombuildsstuff tombuildsstuff merged commit 976b914 into hashicorp:master Oct 2, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for azurerm_app_service Data Source is missing default_site_hostname
2 participants