Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in 'azurerm_api_management_operation' #5243

Closed
wants to merge 166 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
166 commits
Select commit Hold shift + click to select a range
bb7e62d
Move analysis services
mbfrahry Dec 19, 2019
d16ae6d
apimanagement
mbfrahry Dec 19, 2019
36287e6
appconfiguration
mbfrahry Dec 19, 2019
f54a3cd
applicationinsights
mbfrahry Dec 19, 2019
7f816d5
authorization
mbfrahry Dec 19, 2019
c421a59
automation
mbfrahry Dec 19, 2019
3a4261a
batch
mbfrahry Dec 19, 2019
59df731
bot
mbfrahry Dec 19, 2019
ac1a728
cdn
mbfrahry Dec 19, 2019
620c699
cognitive
mbfrahry Dec 19, 2019
8272906
compute
mbfrahry Dec 20, 2019
f177adf
containers
mbfrahry Dec 20, 2019
f18dc07
cosmos
mbfrahry Dec 20, 2019
ce602c1
databricks
mbfrahry Dec 20, 2019
b101faa
datafactory
mbfrahry Dec 20, 2019
4f5fd42
datalake
mbfrahry Dec 20, 2019
4d7a07f
devspace
mbfrahry Dec 20, 2019
5a53130
devtestlabs
mbfrahry Dec 20, 2019
a96d01e
dns
mbfrahry Dec 20, 2019
cd9168b
dns-final
mbfrahry Dec 20, 2019
3b90e55
eventgrid
mbfrahry Dec 20, 2019
26cc648
eventhub
mbfrahry Dec 20, 2019
e20c5d1
frontdoor
mbfrahry Dec 20, 2019
99ea3d1
hdinsight
mbfrahry Dec 20, 2019
ebee833
healthcare
mbfrahry Dec 20, 2019
ee16bc3
iothub
mbfrahry Dec 20, 2019
32d05f1
kusot
mbfrahry Dec 20, 2019
0566de8
loganalytics
mbfrahry Dec 20, 2019
3c9eb75
logic
mbfrahry Dec 20, 2019
db80789
managementgroup
mbfrahry Dec 20, 2019
bd4b1e1
maps
mbfrahry Dec 20, 2019
e47ec2b
mariadb
mbfrahry Dec 20, 2019
58cc7ad
media
mbfrahry Dec 20, 2019
4c0f2bf
monitor
mbfrahry Dec 20, 2019
d45a861
msi
mbfrahry Dec 20, 2019
d81eca8
mysql
mbfrahry Dec 20, 2019
186410f
netapp
mbfrahry Dec 20, 2019
c1b7eb6
network
mbfrahry Dec 20, 2019
09a3ab9
notificationhub
katbyte Dec 20, 2019
29f3941
policy
katbyte Dec 20, 2019
b0e2104
postgres
katbyte Dec 20, 2019
690e4df
privatedns
katbyte Dec 20, 2019
36050fa
recoveryservices
katbyte Dec 20, 2019
ef6da5c
redis
katbyte Dec 20, 2019
34256e1
relay
katbyte Dec 20, 2019
a31d6ec
scheduler
katbyte Dec 20, 2019
00cae30
search
katbyte Dec 20, 2019
70f739e
securitycenter
katbyte Dec 20, 2019
e290d85
servicebus
katbyte Dec 20, 2019
9b84124
servicefabric
katbyte Dec 20, 2019
44262f0
signalr
katbyte Dec 20, 2019
c9c2746
sql
katbyte Dec 20, 2019
7e1e6c5
mssql
katbyte Dec 20, 2019
4b93d0f
streamanalytics
katbyte Dec 20, 2019
e2630a9
web
katbyte Dec 20, 2019
0aea346
more networking
katbyte Dec 20, 2019
ddf5421
trafficmanager
katbyte Dec 20, 2019
51baf38
subscription
katbyte Dec 20, 2019
4596f94
keyvault
katbyte Dec 20, 2019
88d752b
storage
katbyte Dec 20, 2019
9d7aaae
resource 2
katbyte Dec 20, 2019
57218f4
more compute pls
katbyte Dec 20, 2019
a9427b5
network 2
katbyte Dec 20, 2019
6dbe7af
additional authorization
katbyte Dec 20, 2019
e643f7b
remaining resource
katbyte Dec 20, 2019
ba5c535
portal
katbyte Dec 20, 2019
7bb3f93
more monitor
katbyte Dec 20, 2019
913961b
sql: moving the testdata into the package folder
tombuildsstuff Dec 20, 2019
0628ebe
apimanagement: moving the testdata folder
tombuildsstuff Dec 20, 2019
40bf280
testdata: moving into packages
tombuildsstuff Dec 20, 2019
b3a90b6
d/client_config: moving into the authorization package
tombuildsstuff Dec 20, 2019
f28b74a
provider: cleaning up the remaining top-level functions
tombuildsstuff Dec 20, 2019
38da2b4
signalr: fixing the tests
tombuildsstuff Dec 20, 2019
8ac6f93
fix test failures
katbyte Dec 20, 2019
5aa3aaa
refactor: removing a circular reference by moving the init to provider
tombuildsstuff Dec 20, 2019
15ef722
compute: moving proximity placement group to the right package
tombuildsstuff Dec 20, 2019
ee5f60a
resource: fixing the `azurerm_resources` test
tombuildsstuff Dec 20, 2019
3c8244e
compute: fixing the compile errors
tombuildsstuff Dec 20, 2019
7eb93a2
r/mssql_server_security_alert_policy: adding a local CheckDestroy func
tombuildsstuff Dec 20, 2019
c30f566
r/mssql_database_vulnerability_assessment_rule_baseline: switching to…
tombuildsstuff Dec 20, 2019
a90d18f
r/(montitor_)metric_alert_rule: switching to a local template func
tombuildsstuff Dec 20, 2019
9af2fcf
r/mssql_server_vulnerability_assessment: fixing tests
tombuildsstuff Dec 20, 2019
37a5a61
provider: moving the init func
tombuildsstuff Dec 20, 2019
2e32cd5
resources: moving the tests into their own package
tombuildsstuff Dec 20, 2019
4936069
web: updating the tests
tombuildsstuff Dec 20, 2019
d7589e9
trafficmanager: switching to use the new test structure
tombuildsstuff Dec 20, 2019
66edfe7
subscription: switching over to use the new test builder
tombuildsstuff Dec 20, 2019
4ffc3f4
streamanalytics: switching to the new structure
tombuildsstuff Dec 20, 2019
2df5764
test analysisservices
mbfrahry Dec 20, 2019
4f2c89c
apimanagement
mbfrahry Dec 20, 2019
016b2c3
tests: appconfiguration
mbfrahry Dec 20, 2019
758e80c
loganalytics: switching to the new structure
katbyte Dec 20, 2019
cc315f4
logic: switching to the new structure
katbyte Dec 20, 2019
9d36c1e
compute: switching to the new structure
katbyte Dec 21, 2019
435078f
maps: switching to the new test structure
katbyte Dec 21, 2019
e4b0468
managementgroup: switching to the new test structure
katbyte Dec 21, 2019
2c978f2
mariadb: switching to the new test structure
katbyte Dec 21, 2019
c0c7804
tests: storage
mbfrahry Dec 21, 2019
84b1379
sql
mbfrahry Dec 21, 2019
88cf6b8
signalr
mbfrahry Dec 21, 2019
09757c9
tests: servicefabric
mbfrahry Dec 21, 2019
f819172
test: servicebus
mbfrahry Dec 21, 2019
f709541
media: switching to the new test structure
katbyte Dec 21, 2019
4b305fa
monitor: switching to the new test structure
katbyte Dec 21, 2019
6370fee
msi: switching to the new test structure
katbyte Dec 21, 2019
cf71bb6
mssql: switching to the new test structure
katbyte Dec 21, 2019
4770594
mysql: switching to the new test structure
katbyte Dec 21, 2019
9f9cc1e
fixing the tests
tombuildsstuff Dec 21, 2019
1cefa13
removing a circular reference in the provider tests
tombuildsstuff Dec 21, 2019
1589a9b
securitycenter: switching over to the new test structure
tombuildsstuff Dec 21, 2019
d7023ab
search: switching to use the new structure
tombuildsstuff Dec 21, 2019
3dfdd16
scheduler: fixing up the tests
tombuildsstuff Dec 21, 2019
8dceead
relay: fixing up the tests
tombuildsstuff Dec 21, 2019
e94e30c
redis: switching to use the new test structure
tombuildsstuff Dec 21, 2019
da0fb8c
recoveryservices: fixing the tests
tombuildsstuff Dec 21, 2019
d2b2683
privatedns: fixing the tests
tombuildsstuff Dec 21, 2019
ad80b83
postgres: fixing the tests
tombuildsstuff Dec 21, 2019
ea0ead8
portal: fixing the tests
tombuildsstuff Dec 21, 2019
2a148bf
policy: fixing the tests
tombuildsstuff Dec 21, 2019
8ee2520
notificationhub: fixing the tests
tombuildsstuff Dec 21, 2019
64b08f3
netapp: switching to the new test structure
katbyte Dec 21, 2019
262b392
kusto: switching to the new test structure
katbyte Dec 21, 2019
6baeaea
servicebus: fixing up a file that was missed
tombuildsstuff Dec 21, 2019
36810d3
applicationinsights
mbfrahry Dec 21, 2019
ef3cb1e
keyvault: switching to the new test structure
katbyte Dec 21, 2019
b451b52
move keyvault testdata into tests package
katbyte Dec 21, 2019
f53e423
compute: fixing the remnants
tombuildsstuff Dec 21, 2019
ade1e41
iothub: switching to the new test structure
katbyte Dec 21, 2019
262a148
tests: authorization
mbfrahry Dec 21, 2019
9d8ad2b
healthcare: fixing the tests
tombuildsstuff Dec 21, 2019
406edd0
tests: automation
mbfrahry Dec 21, 2019
bb7d9e1
hdinsight: porting over to the new test helper
tombuildsstuff Dec 21, 2019
c0949f0
tests: batch
mbfrahry Dec 21, 2019
6cf5f1e
hdinsight: fixing the type
tombuildsstuff Dec 21, 2019
7c9541d
network: switching to the new test structure
katbyte Dec 21, 2019
69765d7
move batch testdata into tests package
katbyte Dec 21, 2019
d6e1138
move eventhub testdata into tests package
katbyte Dec 21, 2019
ebf57c3
move eventgrid testdata into tests package
katbyte Dec 21, 2019
b05ed70
tests: bot
mbfrahry Dec 21, 2019
e3662f4
dns: switching to the new test structure
katbyte Dec 21, 2019
3348ae3
devtestlabs: switching to the new test structure
katbyte Dec 21, 2019
c327c67
frontdoor: fixing up the tests
tombuildsstuff Dec 21, 2019
820bb79
acceptance: fixing compiler errors
tombuildsstuff Dec 21, 2019
06adcfd
devspace: switching to the new test structure
katbyte Dec 21, 2019
44f1b12
datalake: switching to the new test structure
katbyte Dec 21, 2019
9813c8f
move datalake testdata into tests package
katbyte Dec 21, 2019
5a5fc88
datafactory: switching to the new test structure
katbyte Dec 21, 2019
94bf152
databricks: switching to the new test structure
katbyte Dec 21, 2019
cc8d916
cosmos: switching to the new test structure
katbyte Dec 21, 2019
330aa0c
containers: switching to the new test structure
katbyte Dec 21, 2019
3478750
cognitive: switching to the new test structure
katbyte Dec 21, 2019
1fcf2b1
cdn: switching to the new test structure
katbyte Dec 21, 2019
5667821
graph: switching to the new test structure
katbyte Dec 21, 2019
f026af2
fix error in resource_arm_batch_pool_test.go
katbyte Dec 21, 2019
414b5f0
storage migrations: switching to the new test structure
katbyte Dec 21, 2019
860234b
fix goimport and whitespace errors
katbyte Dec 21, 2019
9ce057a
fix linting errors
katbyte Dec 21, 2019
af587b2
GOGC=5 for linting
katbyte Dec 21, 2019
61a40ba
try and fix travis OOM error
katbyte Dec 22, 2019
c1c09df
travis: temporarily disabling travis2 and travis3
tombuildsstuff Dec 23, 2019
5cd6923
refactor: sorting the keys in the registration structs
tombuildsstuff Dec 23, 2019
c9fccd4
timeouts: fixing the timeouts script to handle the refactor
tombuildsstuff Dec 23, 2019
f6e9c36
registry: adding a check for an empty category
tombuildsstuff Dec 23, 2019
f0f54c0
Fix mistakes and add additional example
BHoggs Dec 19, 2019
51d44c9
Fix panic in 'azurerm_api_management_operation'
Dec 23, 2019
0a3e887
PR Comments resolved
Dec 30, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 0 additions & 8 deletions .golangci-travisrest.yml → .golangci-travis-1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@ linters:
- interfacer
- nakedret
- misspell
- structcheck
- typecheck
- unused
- unconvert
- varcheck
- vet
- vetshadow
- whitespace

linters-settings:
errcheck:
Expand Down
22 changes: 22 additions & 0 deletions .golangci-travis-2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
run:
deadline: 30m10s
modules-download-mode: vendor

issues:
max-per-linter: 0
max-same-issues: 0

linters:
disable-all: true
enable:
- structcheck
- typecheck
- unused
- unconvert

linters-settings:
errcheck:
ignore: github.com/hashicorp/terraform-plugin-sdk/helper/schema:ForceNew|Set,fmt:.*,io:Close
misspell:
ignore-words:
- hdinsight
22 changes: 22 additions & 0 deletions .golangci-travis-3.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
run:
deadline: 30m10s
modules-download-mode: vendor

issues:
max-per-linter: 0
max-same-issues: 0

linters:
disable-all: true
enable:
- varcheck
- vet
- vetshadow
- whitespace

linters-settings:
errcheck:
ignore: github.com/hashicorp/terraform-plugin-sdk/helper/schema:ForceNew|Set,fmt:.*,io:Close
misspell:
ignore-words:
- hdinsight
9 changes: 7 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ matrix:
include:
- name: "make lintstatic"
script: GOGC=15 make lintstatic
- name: "make linttravis"
script: GOGC=15 make lintrest
- name: "make linttravis1"
script: GOGC=5 make lintrest1
# TODO: fix/re-enable in a separate PR
#- name: "make linttravis2"
# script: GOGC=5 make lintrest2
#- name: "make linttravis3"
# script: GOGC=5 make lintrest3
- name: "make tflint"
script: make tflint
- name: "make test"
Expand Down
14 changes: 12 additions & 2 deletions GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,20 @@ lintstatic:
(while true; do sleep 300; echo "(I'm still alive and linting!)"; done) & PID=$$!; echo $$PID; \
golangci-lint run ./... -v --no-config --concurrency 1 --deadline=30m10s --disable-all --enable=staticcheck; ES=$$?; kill -9 $$PID; exit $$ES

lintrest:
lintrest1:
@echo "==> Checking source code against linters..."
(while true; do sleep 300; echo "(I'm still alive and linting!)"; done) & PID=$$!; echo $$PID; \
golangci-lint run ./... -v --concurrency 1 --deadline=30m10s --config .golangci-travisrest.yml ; ES=$$?; kill -9 $$PID; exit $$ES
golangci-lint run ./... -v --concurrency 1 --deadline=30m10s --config .golangci-travis-1.yml ; ES=$$?; kill -9 $$PID; exit $$ES

lintrest2:
@echo "==> Checking source code against linters..."
(while true; do sleep 300; echo "(I'm still alive and linting!)"; done) & PID=$$!; echo $$PID; \
golangci-lint run ./... -v --concurrency 1 --deadline=30m10s --config .golangci-travis-2.yml ; ES=$$?; kill -9 $$PID; exit $$ES

lintrest3:
@echo "==> Checking source code against linters..."
(while true; do sleep 300; echo "(I'm still alive and linting!)"; done) & PID=$$!; echo $$PID; \
golangci-lint run ./... -v --concurrency 1 --deadline=30m10s --config .golangci-travis-2.yml ; ES=$$?; kill -9 $$PID; exit $$ES

tflint:
@echo "==> Checking source code against terraform provider linters..."
Expand Down
91 changes: 0 additions & 91 deletions azurerm/data_source_api_management_api_test.go

This file was deleted.

Loading