Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_frontdoor_firewall_policy - support for exclusions #5407

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

timja
Copy link
Contributor

@timja timja commented Jan 15, 2020

No description provided.

@timja timja force-pushed the add-support-for-exclusions branch from 3ba7319 to 6f19d30 Compare January 15, 2020 16:52
@timja timja requested a review from WodansSon January 16, 2020 07:47
@timja timja force-pushed the add-support-for-exclusions branch 2 times, most recently from 8bf13c2 to 47bdff0 Compare January 17, 2020 14:26
@ghost ghost added size/L and removed size/XXL labels Jan 17, 2020
@timja timja requested a review from katbyte January 17, 2020 14:27
@katbyte katbyte added this to the v1.42.0 milestone Jan 17, 2020
@timja timja force-pushed the add-support-for-exclusions branch from 47bdff0 to 9350413 Compare January 17, 2020 15:13
@tombuildsstuff tombuildsstuff modified the milestones: v1.42.0, v1.43.0 Jan 24, 2020
@WodansSon WodansSon self-assigned this Jan 25, 2020
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timja thank you so much for this PR, looks great! 🚀

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! ⚡️

@katbyte katbyte modified the milestones: v1.43.0, v1.42.0 Jan 25, 2020
@katbyte katbyte merged commit 46e544a into hashicorp:master Jan 25, 2020
katbyte added a commit that referenced this pull request Jan 25, 2020
@timja timja deleted the add-support-for-exclusions branch January 25, 2020 15:44
@ghost
Copy link

ghost commented Jan 27, 2020

This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants