-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_management_group - deprecated and rename group_id
to name
#6276
azurerm_management_group - deprecated and rename group_id
to name
#6276
Conversation
39adb0a
to
e150c12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ArcturusZhang! aside from a couple minor comments this looks pretty good. once they are fixed up this should be good to merge
azurerm/internal/services/managementgroup/tests/data_source_management_group_test.go
Outdated
Show resolved
Hide resolved
Hi @katbyte I fixed the data source test, and removed the deprecation notice in the doc. Please let me know if this is not what you meant... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM @ArcturusZhang
azurerm_management_group
: Add new field name
to replace group_id
group_id
to name
This has been released in version 2.4.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.4.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
The term
group_id
in management group is sometimes confusing with the UUID of the mgmt group or a full ID of a mgmt group. And a mgmt group can have a human-readable string as itsgroup_id
. Thereforegroup_id
is not quite a good term for this.I introduced a new attribute
name
for the resource and data sourceazurerm_management_group
to provide more friendly usage of management group and reduce the confusion.