Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_management_group - deprecated and rename group_id to name #6276

Merged
merged 4 commits into from
Mar 30, 2020

Conversation

ArcturusZhang
Copy link
Contributor

The term group_id in management group is sometimes confusing with the UUID of the mgmt group or a full ID of a mgmt group. And a mgmt group can have a human-readable string as its group_id. Therefore group_id is not quite a good term for this.

I introduced a new attribute name for the resource and data source azurerm_management_group to provide more friendly usage of management group and reduce the confusion.

@ArcturusZhang ArcturusZhang force-pushed the Rename-management-group-id branch from 39adb0a to e150c12 Compare March 27, 2020 06:15
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ArcturusZhang! aside from a couple minor comments this looks pretty good. once they are fixed up this should be good to merge

@ArcturusZhang
Copy link
Contributor Author

Hi @katbyte I fixed the data source test, and removed the deprecation notice in the doc. Please let me know if this is not what you meant...

@ghost ghost removed the waiting-response label Mar 30, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM @ArcturusZhang

@katbyte katbyte changed the title Update resource and data source azurerm_management_group: Add new field name to replace group_id azurerm_management_group - deprecated and rename group_id to name Mar 30, 2020
@katbyte katbyte merged commit 41f8fdc into hashicorp:master Mar 30, 2020
katbyte added a commit that referenced this pull request Mar 30, 2020
@ArcturusZhang ArcturusZhang deleted the Rename-management-group-id branch March 31, 2020 00:24
@ghost
Copy link

ghost commented Apr 2, 2020

This has been released in version 2.4.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.4.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants