-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_private_dns_txt_record #6309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great so far! I'm just calling out some areas we could simplify down and a little more test completeness
azurerm/internal/services/privatedns/resource_arm_private_dns_txt_record.go
Show resolved
Hide resolved
azurerm/internal/services/privatedns/resource_arm_private_dns_txt_record.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/privatedns/resource_arm_private_dns_txt_record.go
Show resolved
Hide resolved
azurerm/internal/services/privatedns/tests/resource_arm_private_dns_txt_record_test.go
Show resolved
Hide resolved
azurerm/internal/services/privatedns/tests/resource_arm_private_dns_txt_record_test.go
Show resolved
Hide resolved
Co-Authored-By: Matthew Frahry <mbfrahry@gmail.com>
39f1495
to
04a8d17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This has been released in version 2.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.5.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fixes #5012