Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'azurerm_virtual_network' - add guid attribute (#2325) #6445

Merged
merged 2 commits into from
Apr 13, 2020
Merged

'azurerm_virtual_network' - add guid attribute (#2325) #6445

merged 2 commits into from
Apr 13, 2020

Conversation

akonrath
Copy link
Contributor

Addresses #2325

  • Add guid (ResourceGUID) attribute to azurerm_virtual_network data source and azurerm_virtual_network resource.
  • Update documentation for d/azurerm_virtual_network and r/azurerm_virtual_network to include guid attribute (Also added a trailing period to an existing attribute for consistency)
  • Fix acceptance test for azurerm_virtual_network data source (reference to address_space should be singular)

katbyte
katbyte approved these changes Apr 12, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @akonrath, aside from two minor comments this LGTM 👍 hope you don't mind but i am going to push the required changes 🙂

azurerm/internal/services/network/resource_arm_virtual_network.go Outdated
Comment on lines 241 to 243
if guid := resp.ResourceGUID; guid != nil {
d.Set("guid", resp.ResourceGUID)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d.Set will check if this is nil for us

azurerm/internal/services/network/data_source_virtual_network.go Outdated
Comment on lines 96 to 98
if guid := resp.ResourceGUID; guid != nil {
d.Set("guid", resp.ResourceGUID)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d.Set will check if this is nil for us

@ghost ghost added size/M and removed size/XS labels Apr 12, 2020
@katbyte katbyte added this to the v2.6.0 milestone Apr 13, 2020
@katbyte katbyte merged commit 3d70c7e into hashicorp:master Apr 13, 2020
katbyte added a commit that referenced this pull request Apr 13, 2020
@katbyte
update CHANGELOG.md to include #6445
364f816
@akonrath
Copy link
Contributor Author

Thank you @katbyte for reviewing and improving it!

@ghost
Copy link

ghost commented Apr 16, 2020

This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.6.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/virtual-networks size/M
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@akonrath @katbyte