azurerm_postgres_server - fix #2819, #5121, #5865, #6180, #6216 #6459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
changed the title
tombuildsstuff
approved these changes
Apr 16, 2020
azurerm/internal/services/postgres/resource_arm_postgresql_server.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/resource_arm_postgresql_server.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/resource_arm_postgresql_server.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/resource_arm_postgresql_server.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/resource_arm_postgresql_server.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/resource_arm_postgresql_server.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/tests/resource_arm_postgresql_server_test.go
Outdated
Show resolved
Hide resolved
katbyte
force-pushed
the
kt/not-yesterdays-postgres-server
branch
from
a691fd3 to
2911d2f
Compare
katbyte
added a commit
that referenced
this pull request
Apr 21, 2020
|
This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.7.0"
}
# ... other configuration ... |
|
@katbyte, you wrote that the following property was renamed: geo_redundant_backup -> backup_geo_redundant_enabled There's a typo in your notes; from looking at the code, the new parameter is actually geo_redundant_backup_enabled Can you edit your initial comment to reflect the correction? |
manicminer
added a commit
that referenced
this pull request
May 8, 2020
- `create_mode`, `creation_source_server_id`, `infrastructure_encryption_enabled`, `ssl_minimal_tls_version_enforced` - Support replicas and point-in-time restores - Use booleans for toggle properties, renaming * `auto_grow` -> `auto_grow_enabled` * `geo_redundant_backup` -> `geo_redundant_backup_enabled` * `ssl_enforcement` -> `ssl_enforcement_enabled` - Remove redundant `storage_profile` block and move all properties within to top level Fixes: #4756 Related: #6459
manicminer
added a commit
that referenced
this pull request
May 11, 2020
- `create_mode`, `creation_source_server_id`, `infrastructure_encryption_enabled`, `ssl_minimal_tls_version_enforced` - Support replicas and point-in-time restores - Use booleans for toggle properties, renaming * `auto_grow` -> `auto_grow_enabled` * `geo_redundant_backup` -> `geo_redundant_backup_enabled` * `ssl_enforcement` -> `ssl_enforcement_enabled` - Remove redundant `storage_profile` block and move all properties within to top level Fixes: #4756 Related: #6459
manicminer
added a commit
that referenced
this pull request
May 11, 2020
- `create_mode`, `creation_source_server_id` - Support replicas and point-in-time restores - Use booleans for toggle properties, renaming * `auto_grow` -> `auto_grow_enabled` * `geo_redundant_backup` -> `geo_redundant_backup_enabled` * `ssl_enforcement` -> `ssl_enforcement_enabled` - Remove redundant `storage_profile` block and move all properties within to top level - Remove unpopulated attribute `administrator_login_password` from `mariadb_server` data source Fixes: #4296, #6521 Related: #6459
manicminer
added a commit
that referenced
this pull request
May 12, 2020
- `create_mode`, `creation_source_server_id` - Support replicas and point-in-time restores - Use booleans for toggle properties, renaming * `auto_grow` -> `auto_grow_enabled` * `geo_redundant_backup` -> `geo_redundant_backup_enabled` * `ssl_enforcement` -> `ssl_enforcement_enabled` - Remove redundant `storage_profile` block and move all properties within to top level - Remove unpopulated attribute `administrator_login_password` from `mariadb_server` data source Fixes: #4296, #6521 Related: #6459
manicminer
added a commit
that referenced
this pull request
May 12, 2020
- `create_mode`, `creation_source_server_id`, `public_network_access_enabled` - Support replicas and point-in-time restores - Use booleans for toggle properties, renaming * `auto_grow` -> `auto_grow_enabled` * `geo_redundant_backup` -> `geo_redundant_backup_enabled` * `ssl_enforcement` -> `ssl_enforcement_enabled` - Remove redundant `storage_profile` block and move all properties within to top level - Remove unpopulated attribute `administrator_login_password` from `mariadb_server` data source Fixes: #4296, #6521 Related: #6459
|
@larryclaman thanks for pointing that out! i've updated the pr description with the correct name |
katbyte
pushed a commit
that referenced
this pull request
May 14, 2020
create_mode, creation_source_server_id, infrastructure_encryption_enabled, ssl_minimal_tls_version_enforced Support replicas and point-in-time restores Use booleans for toggle properties, renaming auto_grow -> auto_grow_enabled geo_redundant_backup -> geo_redundant_backup_enabled ssl_enforcement -> ssl_enforcement_enabled Remove redundant storage_profile block and move all properties within to top level Fixes: #4756 Related: #6459
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor code and tests to
create_mode,creation_source_server_id,infrastructure_encryption_enabled,public_network_access_enabled,ssl_minimal_tls_version_enforcedpropertiesstorage_mbwhenauto_grow_enabledis true--
ssl_enforcement->ssl_enforcement_enabled--
geo_redundant_backup->backup_geo_redundant_enabled--
auto_grow->auto_grow_enabledstorage_profileblock to the top levelsuperseeds #6241
fixes #6216
fixes #6180
fixes #5865
fixes #5121
fixed #2819