Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing request_header_condition flatten part #6541

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Apr 20, 2020

Fixes #6539

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

@r0bnet checking Travis it appears this wants rebasing on top of master, but is otherwise fine - I hope you don't mind but I'll push a rebase for this

@tombuildsstuff tombuildsstuff force-pushed the fix-endpoint-delivery-rule-req-header-condition branch from 4b46080 to 0ae2d06 Compare April 21, 2020 07:29
@tombuildsstuff tombuildsstuff added this to the v2.7.0 milestone Apr 21, 2020
@tombuildsstuff tombuildsstuff merged commit a846409 into hashicorp:master Apr 21, 2020
@tombuildsstuff
Copy link
Contributor

Acceptance tests look good 👍

tombuildsstuff added a commit that referenced this pull request Apr 21, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@r0bnet r0bnet deleted the fix-endpoint-delivery-rule-req-header-condition branch April 28, 2020 17:52
@ghost
Copy link

ghost commented May 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delivery rules - request_header_condition being always added
2 participants