-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sku_name suppress case difference - azurerm_key_vault #8467
Conversation
@katbyte I have added a link to the rest-api-specs issue, could you please have a look again? |
it seems there is some problem with the CI, I will close and reopen it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, Instead of just making it fully case insensitive could we just allow standard
and premium
in addition to the camel cased ones?
@katbyte according to service team's reply Azure/azure-rest-api-specs#10943 (comment) sku_name is not case-sensitive, I am afraid that the portal will change again. I think it's better to make it fully case insensitive |
This comment has been minimized.
This comment has been minimized.
Closing this in favour of #8983 which instead rewrites the casing to ensure it's consistent with what the SDK defines, meaning the configuration is the source of truth here. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
fix #8457
now, the portal's default behaviour for "sku" is "Standard". after terraform import there will be diff because only "standard" and "premium" is accepted.