Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sku_name suppress case difference - azurerm_key_vault #8467

Closed
wants to merge 2 commits into from

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Sep 15, 2020

fix #8457

now, the portal's default behaviour for "sku" is "Standard". after terraform import there will be diff because only "standard" and "premium" is accepted.

@ghost ghost added the size/XS label Sep 15, 2020
@tombuildsstuff tombuildsstuff self-assigned this Sep 21, 2020
@katbyte katbyte added the service/key-vault Key Vault label Sep 24, 2020
@njuCZ
Copy link
Contributor Author

njuCZ commented Sep 25, 2020

@katbyte I have added a link to the rest-api-specs issue, could you please have a look again?

@njuCZ njuCZ closed this Sep 27, 2020
@njuCZ njuCZ reopened this Sep 27, 2020
@njuCZ
Copy link
Contributor Author

njuCZ commented Sep 27, 2020

it seems there is some problem with the CI, I will close and reopen it

@njuCZ njuCZ closed this Sep 27, 2020
@njuCZ njuCZ reopened this Sep 27, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, Instead of just making it fully case insensitive could we just allow standard and premium in addition to the camel cased ones?

@njuCZ
Copy link
Contributor Author

njuCZ commented Oct 9, 2020

@katbyte according to service team's reply Azure/azure-rest-api-specs#10943 (comment) sku_name is not case-sensitive, I am afraid that the portal will change again. I think it's better to make it fully case insensitive

@scp-mb

This comment has been minimized.

@tombuildsstuff
Copy link
Contributor

Closing this in favour of #8983 which instead rewrites the casing to ensure it's consistent with what the SDK defines, meaning the configuration is the source of truth here.

@ghost
Copy link

ghost commented Nov 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect casing for SKU name values when importing azurerm_key_vault
4 participants