azurerm_iothub - Support for public_network_access_enabled
#8586
Conversation
| @@ -403,6 +403,11 @@ func resourceArmIotHub() *schema.Resource { | |||
| }, | |||
| }, | |||
|
|
|||
| "public_network_access": { | |||
| Type: schema.TypeBool, | |||
| Optional: true, | |||
There was a problem hiding this comment.
does this need to default to enabled? it'd be good to confirm with the portal's behaviour
There was a problem hiding this comment.
If you don't specify it when creating an iothub, it doesn't get returned by the api so I don't think we can default it without breaking people.
There was a problem hiding this comment.
You're required to specify it when creating it in the portal. I believe this functionality was added recently. I imagine it's on by default but the api doesn't return it if a user didn't specify it when creating.
| if enabled == devices.Enabled { | ||
| d.Set("public_network_access", true) | ||
| } | ||
| } |
There was a problem hiding this comment.
couldn't we could make this:
| } | |
| publicNetworkAccessEnabled := properties.PublicNetworkAccess == devices.Enabled | |
| d.Set("public_network_access", publicNetworkAccessEnabled) |
|
This is ready for another review @tombuildsstuff |
| @@ -403,6 +403,11 @@ func resourceArmIotHub() *schema.Resource { | |||
| }, | |||
| }, | |||
|
|
|||
| "public_network_access": { | |||
There was a problem hiding this comment.
Should this be public_network_access_enabled ?
mbfrahry
changed the title
azurerm_iothub - Support for public_network_accessazurerm_iothub - Support for public_network_access_enabled
|
This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.31.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Fixes #8508