Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate target host_set_ids and credential_library_ids #134

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

louisruch
Copy link
Contributor

@louisruch louisruch commented Sep 1, 2021

What does this PR do

  • Adds support for new target fields application_credential_source_ids and host_source_ids
  • Deprecates application_credential_library_ids and host_library_ids

@louisruch
Copy link
Contributor Author

@malnick @jefferai I realized that we never updated tf provider to use the new Source fields, so this adds support for the new and deprecated target fields.

@@ -18,11 +18,11 @@ The managed group resource allows you to configure a Boundary group.
### Required

- **auth_method_id** (String) The resource ID for the auth method.
- **filter** (String) Boolean expression to filter the workers for this managed group.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't have been part of this PR but noticed filter incorrectly set as optional

…mple. (#88)

* Include the 'type' attribute in the example.

* run tfplugindocs to generate the new markdown with type attribute change included
Copy link
Contributor

@malnick malnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @louisruch !

@louisruch louisruch merged commit 725f2d8 into main Sep 8, 2021
@louisruch louisruch deleted the louis-updates branch September 8, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants