Add dynamic host plugin catalog/set #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Boundary dep to a version that works for external tests
talanknight
suggested changes
Nov 29, 2021
vancluever
reviewed
Nov 29, 2021
There was a problem hiding this comment.
Mostly observational changes and nits. At least one thing that @talanknight mentioned. Looks like some of these are repeated patterns so any action take should likely be applied through the whole PR.
Co-authored-by: Todd <T.Alan.Knight@gmail.com>
…ink when it happens.
isn't working but outside of that it seems fine.
louisruch
reviewed
Dec 21, 2021
talanknight
suggested changes
Dec 21, 2021
talanknight
approved these changes
Jan 19, 2022
elimt
added a commit
that referenced
this pull request
Jun 22, 2023
- Create a new resource for storage bucket - Add examples and docs for how to use new resource - Tests added but they do not run on purpose and have not been validated yet because we cannot run tests for enterprise features yet. That will be addressed separately ## Considerations - Even though only AWS can be supported today, still added the `pluginID` & `pluginName` fields so it's easy to extend once other plugin types are supported - There is some logic around handling secrets sent to Boundary and validating secret HMAC changes that exist from `boundary_host_catalog_plugin` that was introduced in [PR-159](#159). Used the same logic we've been using for that
elimt
added a commit
that referenced
this pull request
Jun 28, 2023
* feat: add storage bucket resource - Create a new resource for storage bucket - Add examples and docs for how to use new resource - Tests added but they do not run on purpose and have not been validated yet because we cannot run tests for enterprise features yet. That will be addressed separately ## Considerations - Even though only AWS can be supported today, still added the `pluginID` & `pluginName` fields so it's easy to extend once other plugin types are supported - There is some logic around handling secrets sent to Boundary and validating secret HMAC changes that exist from `boundary_host_catalog_plugin` that was introduced in [PR-159](#159). Used the same logic we've been using for that
elimt
added a commit
that referenced
this pull request
Jun 28, 2023
* feat: add storage bucket resource - Create a new resource for storage bucket - Add examples and docs for how to use new resource - Tests added but they do not run on purpose and have not been validated yet because we cannot run tests for enterprise features yet. That will be addressed separately ## Considerations - Even though only AWS can be supported today, still added the `pluginID` & `pluginName` fields so it's easy to extend once other plugin types are supported - There is some logic around handling secrets sent to Boundary and validating secret HMAC changes that exist from `boundary_host_catalog_plugin` that was introduced in [PR-159](#159). Used the same logic we've been using for that
grantorchard
pushed a commit
to grantorchard/terraform-provider-boundary
that referenced
this pull request
Aug 28, 2023
* feat: add storage bucket resource - Create a new resource for storage bucket - Add examples and docs for how to use new resource - Tests added but they do not run on purpose and have not been validated yet because we cannot run tests for enterprise features yet. That will be addressed separately ## Considerations - Even though only AWS can be supported today, still added the `pluginID` & `pluginName` fields so it's easy to extend once other plugin types are supported - There is some logic around handling secrets sent to Boundary and validating secret HMAC changes that exist from `boundary_host_catalog_plugin` that was introduced in [PR-159](hashicorp#159). Used the same logic we've been using for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates existing host resources to static type (adding an explicit static type and deprecating the non-typed version), and creates plugin types for host catalog and host set.
Note: proper operation (specifically attribute null handling) depend on some post-0.7.1 Boundary patches. We could release without these patches in a release of Boundary but there will be some unexpected behavior around setting attributes to null/empty.