Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF updates #201

Merged
merged 6 commits into from
May 16, 2022
Merged

TF updates #201

merged 6 commits into from
May 16, 2022

Conversation

louisruch
Copy link
Contributor

@louisruch louisruch commented May 13, 2022 •
edited
Loading

What does this PR do

  • 3ecf3ff Fixes errors with how we deprecated resource_account. I was not here and perhaps we did plan on exposing attributes via tf. But the current way we are doing this is have a resource per type with type specific attributes. This removes a deprecated warning when using the resource_account_password and clearly explains what users should do with resource_account
  • 9aa514f Updates a number of dependencies including to Boundary 0.8.1
  • 0f5cb98 makes updates needed to support new SDK which calls go-kms-wrapping V2
  • 4c51244 fixes a flaky test, I am not sure what was happening with the regex, but locally it works and I have seen this failing before in CI
  • a01f181 updates a number of documentation errors and run make docs on the latest version
  • 37f3391 updates the changelog

@louisruch
fix(account): Update account deprecations
3ecf3ff 
resource_account has been depreacted in favor of
resource_account_password instead of deprecating the individual password
based fields.
@louisruch louisruch requested review from jefferai and malnick May 13, 2022 23:47
@louisruch
Copy link
Contributor Author

@jefferai or @malnick PTAL I added a summary in the description of each commit

@louisruch louisruch requested a review from talanknight May 16, 2022 18:44
@louisruch louisruch merged commit 8422393 into main May 16, 2022
@louisruch louisruch deleted the louis-updates branch May 16, 2022 21:08
@louisruch louisruch mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talanknight talanknight talanknight approved these changes

@jefferai jefferai Awaiting requested review from jefferai

@malnick malnick Awaiting requested review from malnick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louisruch @talanknight