Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for json credentials #271

Merged
merged 2 commits into from
Sep 29, 2022
Merged

feat: add support for json credentials #271

merged 2 commits into from
Sep 29, 2022

Conversation

ddebko
Copy link
Contributor

@ddebko ddebko commented Sep 21, 2022

Summary:

Added support for static json credential type.

@ddebko ddebko force-pushed the ddebko-kv-credentials branch from 8b743c9 to eded199 Compare September 28, 2022 19:19
@ddebko ddebko force-pushed the ddebko-kv-credentials branch from e5741b5 to 3acbd55 Compare September 28, 2022 20:45
@ddebko ddebko requested a review from louisruch September 28, 2022 20:59
Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment around the test otherwise this looks GREAT!

internal/provider/resource_credential_json_test.go Outdated Show resolved Hide resolved
@ddebko ddebko requested a review from louisruch September 29, 2022 17:30
@ddebko ddebko merged commit 7ae01cc into main Sep 29, 2022
@ddebko ddebko deleted the ddebko-kv-credentials branch September 29, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants