Support Vault Credential Library Mapping Overrides #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
username_attribute
&password_attribute
for vault credential library that is a username_password credential typeusername_attribute
,private_key_attribute
&private_key_passphrase_attribute
for vault credential library that is a ssh_private_key credential typeOpen Questions:
when using the cli to remove an existing mapping override from a vault credential, you need to set the attribute value to null. Example:
I thought that it might be weird to set an attribute value to null in the terraform resource. I think people would naturally try to just remove the resource
credential_mapping_overrides
or an attribute within the map. So I added logic on the update function to handle setting a removed value from the state file to nil for the user.