Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(provider/target): Enable target with address configurations #308

Merged
merged 1 commit into from
Feb 10, 2023
Merged

feat(provider/target): Enable target with address configurations #308

merged 1 commit into from
Feb 10, 2023

Conversation

hugoghx
Copy link
Contributor

@hugoghx hugoghx commented Dec 7, 2022 •
edited
Loading

Requires Boundary changes to be merged and deployed first. Afterwards, references to Boundary need to be updated:

go get github.com/hashicorp/boundary@<version>
go get github.com/hashicorp/boundary/api
go get github.com/hashicorp/boundary/sdk

Despite not building in CI at the moment (due to above constraints), this functionality and tests have been tested locally. Please do not merge yet.

@hugoghx hugoghx self-assigned this Dec 7, 2022
louisruch
louisruch reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@louisruch louisruch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting on this, love to see the provider updated with planned work! Please run make docs or go generate to update the documentation. Might also be good to add an example config with an address https://github.com/hashicorp/terraform-provider-boundary/blob/main/examples/resources/boundary_target/resource.tf#L86

internal/provider/resource_target.go Outdated Show resolved Hide resolved
@hugoghx hugoghx requested a review from louisruch December 8, 2022 12:37
@hugoghx hugoghx mentioned this pull request Dec 22, 2022
Merged
@hugoghx hugoghx force-pushed the hugoamvieira-target-addr branch from 9c4f84f to f5d91fb Compare February 8, 2023 18:41
@hugoghx hugoghx force-pushed the hugoamvieira-target-addr branch from f5d91fb to 8ded451 Compare February 9, 2023 15:27
@hugoghx hugoghx marked this pull request as ready for review February 9, 2023 15:36
@hugoghx hugoghx requested a review from tmessi February 9, 2023 15:36
@hugoghx hugoghx merged commit bd9cc97 into main Feb 10, 2023
@hugoghx hugoghx deleted the hugoamvieira-target-addr branch February 10, 2023 15:13
@macmiranda macmiranda mentioned this pull request Mar 13, 2023
Closed
grantorchard pushed a commit to grantorchard/terraform-provider-boundary that referenced this pull request Aug 28, 2023
@grantorchard
feat(provider/target): Enable target with address configurations (has…
c65b8d5 
…hicorp#308)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmessi tmessi tmessi approved these changes

@louisruch louisruch Awaiting requested review from louisruch

Assignees

@hugoghx hugoghx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugoghx @tmessi @louisruch