Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for vault ssh certificate credential libraries #320

Merged
merged 2 commits into from
Feb 15, 2023
Merged

feat: Add support for vault ssh certificate credential libraries #320

merged 2 commits into from
Feb 15, 2023

Conversation

tmessi
Copy link
Member

@tmessi tmessi commented Feb 8, 2023

No description provided.

@tmessi tmessi requested review from louisruch and hugoghx February 8, 2023 18:57
hugoghx
hugoghx reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@hugoghx hugoghx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the code yet but we probably need some examples for the new resource.

@louisruch
Copy link
Contributor

Haven't reviewed the code yet but we probably need some examples for the new resource.

Also remember to run make docs or go generate to generate the docs

@tmessi tmessi mentioned this pull request Feb 8, 2023
Merged
@tmessi tmessi force-pushed the tmessi-vault-ssh-cert-cl branch 4 times, most recently from 615049a to 733643f Compare February 9, 2023 16:02
@tmessi tmessi force-pushed the tmessi-vault-ssh-cert-cl branch from 733643f to 7ffceda Compare February 10, 2023 15:15
@tmessi
doc(target): Changes from running make docs
e391564 
This seems to be a reordering of the attributes.
@tmessi tmessi force-pushed the tmessi-vault-ssh-cert-cl branch from 7ffceda to e391564 Compare February 15, 2023 15:24
@tmessi tmessi merged commit e891c7e into main Feb 15, 2023
@tmessi tmessi deleted the tmessi-vault-ssh-cert-cl branch February 15, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugoghx hugoghx hugoghx approved these changes

@louisruch louisruch louisruch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmessi @louisruch @hugoghx