fix: Allow users to set OIDC maxAge value to 0 to require immediate reauth #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eauth Previously, setting 0 as a value for maxAge in an OIDC resource block would not update Boundary, as it was getting treated as a nil value in the provider. This fix addresses that issue, ensuring that both setting the value to 0 will require immediate reauthorisation, as well as removing the maxAge paramater defaulting the reauth time length to the TTL of the chose OIDC provider
|
|
mikemountain
commented
Mar 21, 2023
| testAccCheckAuthMethodAttrAryValueSet(provider, "boundary_auth_method_oidc.foo", authmethodOidcIdpCaCertsKey, []string{fooAuthMethodOidcCaCerts}), | ||
| testAccCheckAuthMethodAttrAryValueSet(provider, "boundary_auth_method_oidc.foo", authmethodOidcAllowedAudiencesKey, []string{"foo_aud_update"}), | ||
| testAccCheckAuthMethodResourceExists(provider, "boundary_auth_method_oidc.foo"), | ||
| testAccIsPrimaryForScope(provider, "boundary_auth_method_oidc.foo", true), | ||
| testAccCheckAuthMethodResourceExists(provider, "boundary_auth_method_oidc.foo"), | ||
| ), | ||
| }, | ||
| importStep("boundary_auth_method_oidc.foo", "client_secret", "is_primary_for_scope"), | ||
| importStep("boundary_auth_method_oidc.foo", "client_secret", "is_primary_for_scope", authmethodOidcMaxAgeKey), |
There was a problem hiding this comment.
The workaround unfortunately has to keep a -1 in the Terraform state, which isn't reflected in Boundary (as it gets removed). Went with ignoring checking for that difference, with checking that the -1 does exist as an attribute above in the tests
johanbrandhorst
approved these changes
Mar 21, 2023
|
@mikemountain Before you merge this lets have a chat |
mikemountain
added a commit
that referenced
this pull request
Apr 21, 2023
…eauth (#364) * fix: Allow users to set OIDC maxAge value to 0 to require immediate reauth Previously, setting 0 as a value for maxAge in an OIDC resource block would not update Boundary, as it was getting treated as a nil value in the provider. This fix addresses that issue, ensuring that both setting the value to 0 will require immediate reauthorisation, as well as removing the maxAge paramater defaulting the reauth time length to the TTL of the chose OIDC provider * Update doc strings, fix imports, and run go generate * add changes to CHANGELOG
mikemountain
added a commit
that referenced
this pull request
Apr 21, 2023
* fix: Allow users to set OIDC maxAge value to 0 to require immediate reauth (#364) * fix: Allow users to set OIDC maxAge value to 0 to require immediate reauth Previously, setting 0 as a value for maxAge in an OIDC resource block would not update Boundary, as it was getting treated as a nil value in the provider. This fix addresses that issue, ensuring that both setting the value to 0 will require immediate reauthorisation, as well as removing the maxAge paramater defaulting the reauth time length to the TTL of the chose OIDC provider * Update doc strings, fix imports, and run go generate * add changes to CHANGELOG * spelling: host_set_plugin exmaple to example * Update target.md (#349) Update docs for Target resource removing `scope_id` from `boundary_host` resources to prevent error ``` ╷ │ Error: Unsupported argument │ │ on main.tf line 79, in resource "boundary_host" "foo": │ 79: scope_id = boundary_scope.project.id │ │ An argument named "scope_id" is not expected here. ``` * feature: add worker_filter option to Boundary Credential Store Vault (#375) * feature: add worker_filter option to Boundary Credential Store Vault * Update changelog * chore: update deps * small fixes for cherry-picks * downgrade hclog --------- Co-authored-by: mocofound <aharness@hashicorp.com> Co-authored-by: Steven Zamborsky <97125550+stevenzamborsky@users.noreply.github.com> Co-authored-by: Louis Ruch <louisruch@gmail.com>
grantorchard
pushed a commit
to grantorchard/terraform-provider-boundary
that referenced
this pull request
Aug 28, 2023
…eauth (hashicorp#364) * fix: Allow users to set OIDC maxAge value to 0 to require immediate reauth Previously, setting 0 as a value for maxAge in an OIDC resource block would not update Boundary, as it was getting treated as a nil value in the provider. This fix addresses that issue, ensuring that both setting the value to 0 will require immediate reauthorisation, as well as removing the maxAge paramater defaulting the reauth time length to the TTL of the chose OIDC provider * Update doc strings, fix imports, and run go generate * add changes to CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, setting 0 as a value for maxAge in an OIDC resource block would not update Boundary, as it was getting treated as a nil value in the provider.
This fix addresses that issue, ensuring that both setting the value to 0 will require immediate reauthorisation, as well as removing the maxAge paramater defaulting the reauth time length to the TTL of the chosen OIDC provider.