fix: default auth method with recovery kms #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dc primary auth method
… client token isn't null
elimt
changed the title
jimlambrt
approved these changes
May 12, 2023
grantorchard
pushed a commit
to grantorchard/terraform-provider-boundary
that referenced
this pull request
Aug 28, 2023
* add test coverage for authenticating with recovery kms mechanism & oidc primary auth method * Skip fetching default auth method when recovery_kms_hcl is set or the client token isn't null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passwordauth-methodrecovery_kms_hclis set or the client token isn't nullConsiderations
boundary_auth_method_oidc.footest resource's scope to "global" to easily allow testing the default auth methodauth_method_id,password_auth_method_login_name&password_auth_method_passwordfromtestConfigWithRecoverysince those fields are not needed for authenticating with Recovery KMS. Using those fields also previously caused tests to pass with the bug.This should cover test coverage for the bug raised: #404