Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (auth/ldap): support for new ldap fields #453

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

jimlambrt
Copy link
Contributor

support for auth/ldap: maximum_page_size and dereference_aliases

NOTE: this can't be merged until boundary 0.14.0 is released/tagged and boundary along with the API and SDK are updated in this PR.

@jimlambrt jimlambrt requested a review from louisruch September 10, 2023 21:56
Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you just need to run make docs to update the md file with the new fields

@jimlambrt jimlambrt force-pushed the jimlambrt-new-auth-ldap-fields branch from 628c44a to f5f8aaa Compare September 12, 2023 23:24
@jimlambrt jimlambrt requested a review from louisruch September 12, 2023 23:26
Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psekar psekar added this to the 0.14.0 milestone Sep 18, 2023
@jimlambrt jimlambrt force-pushed the jimlambrt-new-auth-ldap-fields branch from f5f8aaa to 62efa7f Compare September 26, 2023 20:14
@jimlambrt jimlambrt merged commit 4ccc196 into main Sep 26, 2023
@jimlambrt jimlambrt deleted the jimlambrt-new-auth-ldap-fields branch September 26, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants