Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update workflows to enable corner testing against Terraform 1.8.0-rc1 #230

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

austinvalle
Copy link
Member

I updated both action variables in this repository to include the RC for v1.8.0 so we can test against functions in our CI. This shouldn't impact any of the framework repositories CI as they don't consume the workflow itself, just clones the repo.

Maybe we should update framework to do the same? Or we can wait 😆

TF_VERSIONS_PROTOCOL_V5

["0.12.*","0.13.*","0.14.*","0.15.*","1.0.*","1.1.*","1.2.*","1.3.*","1.4.*","1.5.*","1.6.*", "1.7.*", "1.8.0-rc1"]

TF_VERSIONS_PROTOCOL_V6

["1.0.*","1.1.*","1.2.*","1.3.*","1.4.*","1.5.*","1.6.*","1.7.*", "1.8.0-rc1"]

@austinvalle austinvalle added the github_actions Pull requests that update GitHub Actions code label Mar 22, 2024
@austinvalle austinvalle requested a review from a team as a code owner March 22, 2024 17:00
@austinvalle austinvalle changed the title CI: Update workflows to enable corner testing against Terraform 1.8.0… CI: Update workflows to enable corner testing against Terraform 1.8.0-rc1 Mar 22, 2024
@austinvalle
Copy link
Member Author

@bflad I updated this PR to the main branch of terraform-plugin-testing to consume: hashicorp/terraform-plugin-testing#316

If we want to update all of our workflows to remove the .* and update our action variable configs to match then I can do that in the upcoming week?

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

If we want to update all of our workflows to remove the .* and update our action variable configs to match then I can do that in the upcoming week?

That sounds like an excellent plan! It'd be great to push out variable changes (potentially including conditionalizing this repository's variables to add prerelease testing) via Terraform. We could also try to get this done together tomorrow if that's better for you.

@austinvalle
Copy link
Member Author

No worries, I'll work through it next week! Will keep the conditional prerelease testing in mind for that.

@austinvalle austinvalle merged commit fdf8e5f into main Mar 29, 2024
69 checks passed
@austinvalle austinvalle deleted the av/temp-workflow-update branch March 29, 2024 16:18
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants