Add Int32 and Float32 type testing #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… create separate tests for Terraform `v1.9.0` and above
# Conflicts: # go.mod # go.sum
austinvalle
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
All the tests here look good, left a couple notes about comments and version choices.
One more place to consider adding smoke tests for Float32Attribute and Int32Attribute is in the basic schema tests:
internal/framework5provider/schema_resource.gointernal/framework5provider/schema_resource_test.gointernal/framework6provider/schema_resource.gointernal/framework6provider/schema_resource_test.go
Great job! 🚀
| }) | ||
| } | ||
|
|
||
| func TestFloat32Function_overflow_underflow(t *testing.T) { |
Comment on lines
+79
to
+82
| // This test documents edge case behavior with math.MaxFloat32 | ||
| // This number is unique in that it has an exact representation in both float32 and float64, | ||
| // it is also an integer, which may affect how this value gets encoded/decoded with go-cty. | ||
| // https://github.com/hashicorp/terraform-plugin-framework/issues/1017 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases for
int32andfloat32function types andfloat32precision testing.