Added COMMENTS_ENABLED_FOR_EXTERNAL_CONTRIBUTORS_ONLY support to gith…

…ub pullRequest commentControl (#4055) (#2552) Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Oct 6, 2020 · 113be9e · 113be9e
1 parent e9f49c1
commit 113be9e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.changelog/4055.txt b/.changelog/4055.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+cloudbuild: Added `COMMENTS_ENABLED_FOR_EXTERNAL_CONTRIBUTORS_ONLY` support to `google_cloudbuild_trigger.github.pull_request.comment_control` field
+```
diff --git a/google-beta/resource_cloud_build_trigger.go b/google-beta/resource_cloud_build_trigger.go
@@ -678,8 +678,8 @@ https://github.com/googlecloudplatform/cloud-builders is "googlecloudplatform".`
 									"comment_control": {
 										Type:         schema.TypeString,
 										Optional:     true,
-										ValidateFunc: validation.StringInSlice([]string{"COMMENTS_DISABLED", "COMMENTS_ENABLED", ""}, false),
-										Description:  `Whether to block builds on a "/gcbrun" comment from a repository owner or collaborator. Possible values: ["COMMENTS_DISABLED", "COMMENTS_ENABLED"]`,
+										ValidateFunc: validation.StringInSlice([]string{"COMMENTS_DISABLED", "COMMENTS_ENABLED", "COMMENTS_ENABLED_FOR_EXTERNAL_CONTRIBUTORS_ONLY", ""}, false),
+										Description:  `Whether to block builds on a "/gcbrun" comment from a repository owner or collaborator. Possible values: ["COMMENTS_DISABLED", "COMMENTS_ENABLED", "COMMENTS_ENABLED_FOR_EXTERNAL_CONTRIBUTORS_ONLY"]`,
 									},
 									"invert_regex": {
 										Type:        schema.TypeBool,

diff --git a/website/docs/r/cloudbuild_trigger.html.markdown b/website/docs/r/cloudbuild_trigger.html.markdown
@@ -270,7 +270,7 @@ The `pull_request` block supports:
 * `comment_control` -
   (Optional)
   Whether to block builds on a "/gcbrun" comment from a repository owner or collaborator.
-  Possible values are `COMMENTS_DISABLED` and `COMMENTS_ENABLED`.
+  Possible values are `COMMENTS_DISABLED`, `COMMENTS_ENABLED`, and `COMMENTS_ENABLED_FOR_EXTERNAL_CONTRIBUTORS_ONLY`.
 
 * `invert_regex` -
   (Optional)