Skip to content

Commit

Permalink
adds scaling properties to appengine standard version (#3373) (#1984)
Browse files Browse the repository at this point in the history
* adds scaling properties to appengine standard version

* use optional scaling properties

as it defaults to automaticScaling

* cover all automatic_scaling properties during test

* update test for standard appengine version

Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
modular-magician authored Apr 23, 2020
1 parent eda1901 commit 3bcc06d
Show file tree
Hide file tree
Showing 7 changed files with 929 additions and 41 deletions.
3 changes: 3 additions & 0 deletions .changelog/3373.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
appengine: Added `automatic_scaling` `basic_scaling` and `manual_scaling` to `google_app_engine_standard_app_version`
```
9 changes: 6 additions & 3 deletions google-beta/resource_app_engine_flexible_app_version.go
Original file line number Diff line number Diff line change
Expand Up @@ -552,9 +552,12 @@ Defaults to F1 for AutomaticScaling and B1 for ManualScaling.`,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"instances": {
Type: schema.TypeInt,
Required: true,
Description: `Number of instances to assign to the service at the start. This number can later be altered by using the Modules API set_num_instances() function.`,
Type: schema.TypeInt,
Required: true,
Description: `Number of instances to assign to the service at the start.
**Note:** When managing the number of instances at runtime through the App Engine Admin API or the (now deprecated) Python 2
Modules API set_num_instances() you must use 'lifecycle.ignore_changes = ["manual_scaling"[0].instances]' to prevent drift detection.`,
},
},
},
Expand Down
Loading

0 comments on commit 3bcc06d

Please sign in to comment.