fix notification channel test (#3037) (#1696)

Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Jan 29, 2020 · 4ef00d4 · 4ef00d4
1 parent b2aace7
commit 4ef00d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.changelog/3037.txt b/.changelog/3037.txt
diff --git a/google-beta/data_source_monitoring_notification_channel_test.go b/google-beta/data_source_monitoring_notification_channel_test.go
@@ -159,22 +159,26 @@ data "google_monitoring_notification_channel" "default" {
 `, displayName, displayName)
 }
 
-func testAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndUserLabel(displayName string) string {
+func testAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndUserLabel(testName string) string {
 	return fmt.Sprintf(`
 resource "google_monitoring_notification_channel" "default" {
   display_name = "%s"
   type         = "email"
 
+  labels = {
+    email_address = "%s@google.com"
+  }
+
   user_labels = {
-    testname = "%s"
+    testname = "foo-%s"
   }
 }
 
 data "google_monitoring_notification_channel" "default" {
   type = google_monitoring_notification_channel.default.type
   user_labels =  google_monitoring_notification_channel.default.user_labels
 }
-`, displayName, displayName)
+`, testName, testName, testName)
 }
 
 func testAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType(displayName string) string {