allow setting firewall priority to 0 (#755)

Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · May 28, 2019 · cc025be · cc025be
1 parent 72c9bfd
commit cc025be
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/google-beta/resource_compute_firewall.go b/google-beta/resource_compute_firewall.go
@@ -292,7 +292,7 @@ func resourceComputeFirewallCreate(d *schema.ResourceData, meta interface{}) err
 	priorityProp, err := expandComputeFirewallPriority(d.Get("priority"), d, config)
 	if err != nil {
 		return err
-	} else if v, ok := d.GetOkExists("priority"); !isEmptyValue(reflect.ValueOf(priorityProp)) && (ok || !reflect.DeepEqual(v, priorityProp)) {
+	} else if v, ok := d.GetOkExists("priority"); ok || !reflect.DeepEqual(v, priorityProp) {
 		obj["priority"] = priorityProp
 	}
 	sourceRangesProp, err := expandComputeFirewallSourceRanges(d.Get("source_ranges"), d, config)
@@ -494,7 +494,7 @@ func resourceComputeFirewallUpdate(d *schema.ResourceData, meta interface{}) err
 	priorityProp, err := expandComputeFirewallPriority(d.Get("priority"), d, config)
 	if err != nil {
 		return err
-	} else if v, ok := d.GetOkExists("priority"); !isEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, priorityProp)) {
+	} else if v, ok := d.GetOkExists("priority"); ok || !reflect.DeepEqual(v, priorityProp) {
 		obj["priority"] = priorityProp
 	}
 	sourceRangesProp, err := expandComputeFirewallSourceRanges(d.Get("source_ranges"), d, config)