Deflake test (#4680) (#3154)

Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Apr 14, 2021 · db911ca · db911ca
1 parent 50178c3
commit db911ca
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changelog/4680.txt b/.changelog/4680.txt
@@ -0,0 +1,3 @@
+```release-note:none
+
+```
diff --git a/google-beta/resource_service_usage_consumer_quota_override_generated_test.go b/google-beta/resource_service_usage_consumer_quota_override_generated_test.go
@@ -172,9 +172,12 @@ func testAccCheckServiceUsageConsumerQuotaOverrideDestroyProducer(t *testing.T)
 				billingProject = config.BillingProject
 			}
 
-			_, err = sendRequest(config, "GET", billingProject, url, config.userAgent, nil)
+			res, err := sendRequest(config, "GET", billingProject, url, config.userAgent, nil)
 			if err == nil {
-				return fmt.Errorf("ServiceUsageConsumerQuotaOverride still exists at %s", url)
+				// Sometimes the API returns an empty response instead of erroring, treat empty as nonexistent
+				if len(res) != 0 {
+					return fmt.Errorf("ServiceUsageConsumerQuotaOverride still exists at %s", url)
+				}
 			}
 		}