Skip to content

Commit

Permalink
dns/api.yaml: add missing record types (#4689) (#3160)
Browse files Browse the repository at this point in the history
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.

Closes hashicorp/terraform-provider-google#8897

Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
modular-magician authored Apr 15, 2021
1 parent 927f4c0 commit dc1f3ec
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions .changelog/4689.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
dns: added missing record types to `google_dns_record_set` resource
```
4 changes: 2 additions & 2 deletions google-beta/resource_dns_resource_dns_record_set.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ func resourceDNSResourceDnsRecordSet() *schema.Resource {
"type": {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{"A", "AAAA", "CAA", "CNAME", "MX", "NAPTR", "NS", "PTR", "SOA", "SPF", "SRV", "TLSA", "TXT"}, false),
Description: `One of valid DNS resource types. Possible values: ["A", "AAAA", "CAA", "CNAME", "MX", "NAPTR", "NS", "PTR", "SOA", "SPF", "SRV", "TLSA", "TXT"]`,
ValidateFunc: validation.StringInSlice([]string{"A", "AAAA", "CAA", "CNAME", "DNSKEY", "DS", "IPSECVPNKEY", "MX", "NAPTR", "NS", "PTR", "SOA", "SPF", "SRV", "SSHFP", "TLSA", "TXT"}, false),
Description: `One of valid DNS resource types. Possible values: ["A", "AAAA", "CAA", "CNAME", "DNSKEY", "DS", "IPSECVPNKEY", "MX", "NAPTR", "NS", "PTR", "SOA", "SPF", "SRV", "SSHFP", "TLSA", "TXT"]`,
},
"rrdatas": {
Type: schema.TypeList,
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/dns_resource_dns_record_set.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ The following arguments are supported:
* `type` -
(Required)
One of valid DNS resource types.
Possible values are `A`, `AAAA`, `CAA`, `CNAME`, `MX`, `NAPTR`, `NS`, `PTR`, `SOA`, `SPF`, `SRV`, `TLSA`, and `TXT`.
Possible values are `A`, `AAAA`, `CAA`, `CNAME`, `DNSKEY`, `DS`, `IPSECVPNKEY`, `MX`, `NAPTR`, `NS`, `PTR`, `SOA`, `SPF`, `SRV`, `SSHFP`, `TLSA`, and `TXT`.

* `managed_zone` -
(Required)
Expand Down

0 comments on commit dc1f3ec

Please sign in to comment.