Skip to content

Commit

Permalink
Reapply bigtable patch (#3395) (#1968)
Browse files Browse the repository at this point in the history
* Allow one and two nodes production bigtable clusters

* Allow one and two nodes production bigtable clusters

Co-authored-by: vitovitolo <vitovito@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: vitovitolo <vitovito@gmail.com>
  • Loading branch information
modular-magician and vitovitolo authored Apr 21, 2020
1 parent 6589c9e commit e402daa
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions .changelog/3395.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
bigtable: Reduced the minimum number of nodes for the `bigtable_instace` resource from 3 to 1.
```
2 changes: 1 addition & 1 deletion google-beta/resource_bigtable_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func resourceBigtableInstance() *schema.Resource {
// DEVELOPMENT instances could get returned with either zero or one node,
// so mark as computed.
Computed: true,
ValidateFunc: validation.IntAtLeast(3),
ValidateFunc: validation.IntAtLeast(1),
},
"storage_type": {
Type: schema.TypeString,
Expand Down
4 changes: 2 additions & 2 deletions website/docs/r/bigtable_instance.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ resource "google_bigtable_instance" "production-instance" {
cluster {
cluster_id = "tf-instance-cluster"
zone = "us-central1-b"
num_nodes = 3
num_nodes = 1
storage_type = "HDD"
}
}
Expand Down Expand Up @@ -73,7 +73,7 @@ cluster must have a different zone in the same region. Zones that support
Bigtable instances are noted on the [Cloud Bigtable locations page](https://cloud.google.com/bigtable/docs/locations).

* `num_nodes` - (Optional) The number of nodes in your Cloud Bigtable cluster.
Required, with a minimum of `3` for a `PRODUCTION` instance. Must be left unset
Required, with a minimum of `1` for a `PRODUCTION` instance. Must be left unset
for a `DEVELOPMENT` instance.

* `storage_type` - (Optional) The storage type to use. One of `"SSD"` or
Expand Down

0 comments on commit e402daa

Please sign in to comment.