Update CHANGELOG #2192
Merged
Update CHANGELOG #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
slevenick
reviewed
Jun 17, 2020
emilymye
force-pushed
the
release-3.27.0-changelog
branch
2 times, most recently
from
bb89dfa to
97d37fe
Compare
danawillow
reviewed
Jun 17, 2020
danawillow
reviewed
Jun 17, 2020
| * compute: Added `cpu_over_commit_type` to `google_compute_node_template` ([#2176](https://github.com/terraform-providers/terraform-provider-google-beta/pull/2176)) | ||
| * compute: Added `min_node_cpus` to the `scheduling` blocks on `compute_instance` and `compute_instance_template` ([#2169](https://github.com/terraform-providers/terraform-provider-google-beta/pull/2169)) | ||
| * compute: Added `export_subnet_routes_with_public_ip` and `import_subnet_routes_with_public_ip` to `google_compute_network_peering` ([#2170](https://github.com/terraform-providers/terraform-provider-google-beta/pull/2170)) | ||
| * compute: Added `remove_instance_state_on_destroy` to `google_compute_per_instance_config` to control deletion of underlying instance state. ([#2187](https://github.com/terraform-providers/terraform-provider-google-beta/pull/2187)) |
There was a problem hiding this comment.
As per GoogleCloudPlatform/magic-modules#3635 (comment), should this be documented in a breaking changes section?
There was a problem hiding this comment.
@slevenick and I discussed offline and it's not technically a breaking change so we decided to leave it as is. If anything, we could add a note or bug fix to describe our handling of the deletion behavior.
emilymye
force-pushed
the
release-3.27.0-changelog
branch
from
97d37fe to
066392a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.