Update google_billing_budget resource to add last_period_amount #2378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#5245
This uses overrides for a boolean to transform it into an empty block, as the
LastPeriodAmount
field in thebillingAccounts.budgets
API doesn't currently have any configureable properties. See details in API documentation.This workaround was mentioned by @danawillow in the above issue and is being used in BigTable AppProfile. I can also see it's now being used in the dns and secret manager resources.
In the Terraform example / test I've added somewhat of a disclaimer. I don't think this is typical, but felt this was needed to call out it's not a "good" example of how actually to set the
threshold_percent
value, and it could be confusing if not mentioned (people may assume 10.0 = 10% when it's actually 1000%).My concern is if this is set to a more normal value (e.g. 1.0) it could trigger actual email alerts to Billing Admins when running tests.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3860