Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Losss Prevention resources #2433

Conversation

modular-magician
Copy link
Collaborator

First two, InspectTemplate and JobTrigger.

Both of these use parent that could contain several different possibilities to avoid regionalizing these resources into 2/4 nearly identical resources.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_data_loss_prevention_job_trigger
google_data_loss_prevention_inspect_template

Derived from GoogleCloudPlatform/magic-modules#3893

* Starting to add job trigger

* Compiles

* Add example

* Test starts

* Test for job passes, starting inspect template

* Add support for inspect template

* Add tests

* Various formatting fixes, dates

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xxl label Aug 26, 2020
@modular-magician modular-magician merged commit bd42516 into hashicorp:master Aug 26, 2020
@modular-magician modular-magician deleted the downstream-pr-44f84cd9a0244283e01e07c74e440782a17d7e05 branch November 16, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant