Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TPUs to use Shared VPC #2497

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Enable TPUs to use Shared VPC #2497

merged 1 commit into from
Sep 17, 2020

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#7117

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

tpu: added `use_service_networking` to `google_tpu_node` which enables Shared VPC Support.

Derived from GoogleCloudPlatform/magic-modules#3939

@modular-magician
Enable TPUs to use Shared VPC (hashicorp#3939)
dc93755 
* add support for shared vpc

* make cidr_block computable

* add diffsuppression

* tweak diffsupression to ignore when network has a change

* rework diffsupress

* add customizediff

* switch the diff checks

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit b01dd2e into hashicorp:master Sep 17, 2020
@modular-magician modular-magician deleted the downstream-pr-b5b2cebc8a7ce78f49d9e31ccdbe49c75d2be1f4 branch November 16, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TPU shared VPC
1 participant
@modular-magician