Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google_identity_group. #2507

Conversation

modular-magician
Copy link
Collaborator

The enum has only one possible value and seems to be required in all cases.
This broke all existing terraform customers - and likely all API clients.
It has not been fixed in the autogenerated API tools, and it is not reflected in the docs.
I have reached out to the team to see if there is a possibility of fixing existing customers without an upgrade.

Fixes hashicorp/terraform-provider-google#7285.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Fixed upstream breakage of `google_identity_group`.

Derived from GoogleCloudPlatform/magic-modules#3996

* This resource has a newly-mandatory enum field.

The enum has only one possible value and seems to be required in all cases.
This broke all existing terraform customers - and likely all API clients.
It has not been fixed in the autogenerated API tools, and it is not reflected in the docs.
I have reached out to the team to see if there is a possibility of fixing the existing customers.

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 45c4cc2 into hashicorp:master Sep 21, 2020
nat-henderson pushed a commit that referenced this pull request Sep 21, 2020
* This resource has a newly-mandatory enum field.

The enum has only one possible value and seems to be required in all cases.
This broke all existing terraform customers - and likely all API clients.
It has not been fixed in the autogenerated API tools, and it is not reflected in the docs.
I have reached out to the team to see if there is a possibility of fixing the existing customers.

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician deleted the downstream-pr-c8a9f872e19597f0d515d4779ed970f8f0e6dd92 branch November 16, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_cloud_identity_group fails to create
1 participant