Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Region field to dataflow_flex_template_job #2520

Conversation

modular-magician
Copy link
Collaborator

Dataflow flex template jobs use region, but no region field is present on the Terraform resource.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
    Magic modules setup fails for me on debug inspector.
    make: *** No rule to make target `/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/include/ruby-2.6.0/universal-darwin19/ruby/config.h', needed by `debug_inspector.o'. Stop.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
    Terraform provider not generated
  • Read the Release Notes Guide before writing my release note below.
dataflow: Add `region` field to `google_dataflow_flex_template_job` resource

Derived from GoogleCloudPlatform/magic-modules#4019

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 48d75a9 into hashicorp:master Sep 26, 2020
@modular-magician modular-magician deleted the downstream-pr-06a09ffe20ad55ff410f8620f736ef2687daed70 branch November 16, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant