Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DLP deidentify templates #2524

Conversation

modular-magician
Copy link
Collaborator

This is only a partial implementation. Many of the fields are not implemented, but should be as requested.

Tests pass now as API bug has been fixed
Fixes: hashicorp/terraform-provider-google#3898

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_data_loss_prevention_deidentify_template

Derived from GoogleCloudPlatform/magic-modules#3931

* Adding deidentify product

* Add deidentify template

* Rebase, sdk update

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 6331e2f into hashicorp:master Sep 28, 2020
@modular-magician modular-magician deleted the downstream-pr-93eae1ad57ad2c24f86a4191c909b37c1abcdc50 branch November 16, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for DLP Resources
1 participant