Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape folder display name with string quotes #2528

Conversation

modular-magician
Copy link
Collaborator

This is the recommended way to escape these strings according to the API: https://cloud.google.com/resource-manager/reference/rest/v2beta1/folders/search

Fixes: hashicorp/terraform-provider-google#7385

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

resourcemanager: Fixed a bug in retrieving `google_active_folder` data source when the display name included whitespace

Derived from GoogleCloudPlatform/magic-modules#4032

…ing. (hashicorp#4032)

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 1276685 into hashicorp:master Sep 30, 2020
@modular-magician modular-magician deleted the downstream-pr-f77e7909ddf29171d7476fedd7492dd91e406d68 branch November 16, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_active_folder doesn't find folders with dash in displayName
1 participant