Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow management of old AppEngine resources from before CLOUD_DATASTORE_COMPATIBILITY. #2533

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Allow management of old AppEngine resources from before CLOUD_DATASTORE_COMPATIBILITY. #2533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/4006.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
appengine: allowed management of pre-firestore appengine applications.
```
4 changes: 4 additions & 0 deletions google-beta/resource_app_engine_application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ func resourceAppEngineApplication() *schema.Resource {
ValidateFunc: validation.StringInSlice([]string{
"CLOUD_FIRESTORE",
"CLOUD_DATASTORE_COMPATIBILITY",
// NOTE: this is provided for compatibility with instances from
// before CLOUD_DATASTORE_COMPATIBILITY - it cannot be set
// for new instances.
"CLOUD_DATASTORE",
}, false),
Computed: true,
},
Expand Down
3 changes: 3 additions & 0 deletions website/docs/r/app_engine_application.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ The following arguments are supported:
* `auth_domain` - (Optional) The domain to authenticate users with when using App Engine's User API.

* `database_type` - (Optional) The type of the Cloud Firestore or Cloud Datastore database associated with this application.
Can be `CLOUD_FIRESTORE` or `CLOUD_DATASTORE_COMPATIBILITY` for new
instances. To support old instances, the value `CLOUD_DATASTORE` is accepted
by the provider, but will be rejected by the API.

* `serving_status` - (Optional) The serving status of the app.

Expand Down