Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override artifact registry self_link and self_link iam override #2546

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#7324
The self_link and id formatting for google_artifact_registry_repository were incorrect.

Updating these affected the IAM policy by changing the field repository to be repository_id (which is more correct, but would be a breaking change). IAM changes in this PR are to prevent changes in the IAM policy from generating.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

artifactregistry: fixed an issue where `google_artifact_registry_repository` would import an empty state

Derived from GoogleCloudPlatform/magic-modules#4054

…icorp#4054)

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 05c81e4 into hashicorp:master Oct 5, 2020
@modular-magician modular-magician deleted the downstream-pr-d8a3c107d5ee8bce4b2e1463e1807bab32ed2e90 branch November 16, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifact registry import broken
1 participant