Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run sql precheck if projects.get call fails #2634

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#7595

Reproduced locally, and this fixes the error the user experienced. This requires a whole bunch of host project / service project IAM setup that doesn't make it worth setting up an integration test for imo.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: fixed a case in `google_sql_database_instance` where we inadvertently required the `projects.get` permission for a service networking precheck introduced in `v3.44.0`

Derived from GoogleCloudPlatform/magic-modules#4141

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/s label Oct 23, 2020
@modular-magician modular-magician merged commit bd4b5c2 into hashicorp:master Oct 23, 2020
@modular-magician modular-magician deleted the downstream-pr-fae92c23bda82ee3458f2628ddcea7327e4cdf8a branch November 16, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudSQL behavior change v3.44.0
1 participant