Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conditions to Cloud Asset Feeds #2640

Conversation

modular-magician
Copy link
Collaborator

Added conditions to Cloud Asset Inventory feeds.
Conditions were recently added to the API:
https://cloud.google.com/asset-inventory/docs/reference/rest/v1/feeds#Feed
https://cloud.google.com/asset-inventory/docs/reference/rest/Shared.Types/Expr

Fixes hashicorp/terraform-provider-google#7364

If this PR is for Terraform, I acknowledge that I have:

  • [ X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloud_asset: Added `condition` to `google_cloud_asset_organization_feed`
cloud_asset: Added `condition` to `google_cloud_asset_folder_feed`
cloud_asset: Added `condition` to `google_cloud_asset_project_feed`

Derived from GoogleCloudPlatform/magic-modules#4023

* Added conditions block to asset feeds

* Remove unecessary "required" attributes.

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xl label Oct 26, 2020
@modular-magician modular-magician merged commit 83703c2 into hashicorp:master Oct 26, 2020
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this pull request Dec 15, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this pull request Dec 15, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician deleted the downstream-pr-4eb854257e94c4046a37bac1611532b29bec961f branch November 16, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add conditions to Asset Inventory feeds
1 participant