Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write a new custom import that can extract taxonomy and name both. #2744

Merged
merged 1 commit into from
Nov 30, 2020
Merged

write a new custom import that can extract taxonomy and name both. #2744

merged 1 commit into from
Nov 30, 2020

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#7867

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

datacatalog: fixed permadiff on import for tags with a taxonomy set in config.

Derived from GoogleCloudPlatform/magic-modules#4262

@modular-magician
write a new custom import that can extract taxonomy and name both. (h…
f529e93 
…ashicorp#4262)

* write a new custom import that can extract taxonomy and name both.

* move custom import to subfolder.

* update because project and location are set in the parent actually

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Nov 30, 2020
@modular-magician modular-magician merged commit 90096cd into hashicorp:master Nov 30, 2020
@modular-magician modular-magician deleted the downstream-pr-70e2ea347e898bdbc66b1d6cfded174f41901b71 branch November 16, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diff in imported google_data_catalog_policy_tag resource (beta)
1 participant
@modular-magician