Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Billing Budgets to GA #2789

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Promote Billing Budgets to GA #2789

merged 1 commit into from
Dec 15, 2020

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Dec 15, 2020 •
edited by c2thorn
Loading

Fixes: hashicorp/terraform-provider-google#7877
Fixes: hashicorp/terraform-provider-google#7890

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

billing: removed import support for `google_billing_budget` as it never functioned correctly

billing: promoted `google_billing_budget` to GA

Derived from GoogleCloudPlatform/magic-modules#4273

@modular-magician @upodroid
Promote Billing Budgets to GA (hashicorp#4273)
9c86d85 
* promote billing budgets to GA

Co-authored-by: upodroid <cy@borg.dev>

* fix how the deprecations are being handled

Co-authored-by: upodroid <cy@borg.dev>

* patch doc location

Co-authored-by: upodroid <cy@borg.dev>

* fix the nested fields

Co-authored-by: upodroid <cy@borg.dev>

* fix imports

* set more fields to computed

* rejig MM to allow generated importless tests

Co-authored-by: upodroid <cy@borg.dev>
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xxl label Dec 15, 2020
@modular-magician modular-magician merged commit 99fdadb into hashicorp:master Dec 15, 2020
@modular-magician modular-magician deleted the downstream-pr-46236fcb8051cfbd3643d364f652e6196a1b0e5f branch November 16, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/xxl
Projects
None yet
Milestone
No milestone
1 participant
@modular-magician