Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diff suppress for max retry 0s on google_cloud_tasks_queue.retry_config.max_retry_duration #2812

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Add diff suppress for max retry 0s on google_cloud_tasks_queue.retry_config.max_retry_duration #2812

merged 1 commit into from
Dec 23, 2020

Conversation

modular-magician
Copy link
Collaborator

resolves 8028

Adding diff suppress for max retry 0s on google_cloud_tasks_queue.retry_config.max_retry_duration
If the user specifies 0s the api omits this field in the response.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloud_tasks: fixed permadiff on retry_config.max_retry_duration for `google_cloud_tasks_queue` when the 0s is supplied

Derived from GoogleCloudPlatform/magic-modules#4337

@modular-magician
Add diff suppress for max retry 0s on google_cloud_tasks_queue.retry_…
f326157 
…config.max_retry_duration (hashicorp#4337)

* adding diff supress for max retry 0s

* update file extension in comment to be accurate

* Update cloud_tasks_retry_config_custom_diff.go

* line too long. me make line less long

* update to pass rake test

* Update file_template.rb

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added size/s labels Dec 23, 2020
@modular-magician modular-magician merged commit c3ac561 into hashicorp:master Dec 23, 2020
@modular-magician modular-magician deleted the downstream-pr-8f9e4f0154a96876e08951904b6d86340b490681 branch November 16, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_cloud_tasks_queue diff on retry_config.max_retry_duration
1 participant
@modular-magician