Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed google_logging_project_sink.disabled can not updated #2821

Conversation

modular-magician
Copy link
Collaborator

…to true

Fixes hashicorp/terraform-provider-google#8035

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Logging: fixed updating on disabled in `google_logging_project_sink`

Derived from GoogleCloudPlatform/magic-modules#4340

…#4340)

* Fixed google_logging_project_sink.disabled can not be set from false to true

* fixed a typo

* updated the test by adding a step

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added size/m labels Dec 29, 2020
@modular-magician modular-magician merged commit de3618d into hashicorp:master Dec 29, 2020
@modular-magician modular-magician deleted the downstream-pr-9fc909842a4f120019ffafe30de5b4473e73fe18 branch November 16, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_logging_project_sink.disabled can't be updated
1 participant