Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Context Aware Access UserAccessBinding resource #2851

Conversation

modular-magician
Copy link
Collaborator

Resolved hashicorp/terraform-provider-google#7501

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
    ^ --- I'm not able to run acceptance tests (TestAccAccessContextManager) locally because they require a CUST_ID. However, you can see the results in the teamcity tests.
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

accesscontextmanager: Added support for `google_access_context_manager_gcp_user_access_binding`

Derived from GoogleCloudPlatform/magic-modules#4368

…icorp#4368)

* Added basic GcpUserAccessBinding skeleton

* Corrected GcpUserAccessBinding base url and parameters

* Updated GcpUserAccessBinding example to include cloud identity group

* Exclude GcpUserAccessBinding from inspec

* Run gcp user access binding tests as part of access policy tests

* Trim groups/ prefix from group id

This should make the value match what gcp_user_access_binding expects

* Corrected trimprefix usage

* Added trimprefix usage to example

* Added handling of metadata field by operation waiters

* Added explicit self_link of {{name}}

* Marked group_key as input: true because it is required and immutable

* Switched to camel case for parameter/property names

* Use self link for import link

Follows pattern of UptimeCheckConfig and others.

* Switched custom_import because self_link_as_name expects project in path

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xl label Jan 11, 2021
@modular-magician modular-magician merged commit 1996d12 into hashicorp:master Jan 11, 2021
@modular-magician modular-magician deleted the downstream-pr-3956192aaa28962ea7c6f8be63021adb266a02e3 branch November 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccessContextManager Context Aware Access UserAccessBinding resource
1 participant