Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secretmanager: point beta provider to v1 of the api #2946

Conversation

modular-magician
Copy link
Collaborator

The v1 api is a superset of v1beta1. New features are added to v1 and not v1beta1.

Part of hashicorp/terraform-provider-google#8415

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

secretmanager: pointed beta provider to v1 of the api instead of v1beta1 as active development is against v1

Derived from GoogleCloudPlatform/magic-modules#4479

The v1 api is a superset of v1beta1. New features are added to v1 and not v1beta1.

See hashicorp/terraform-provider-google#8415

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Feb 10, 2021
@modular-magician modular-magician merged commit c78c312 into hashicorp:master Feb 10, 2021
@modular-magician modular-magician deleted the downstream-pr-84a5e1bdbaa3cb7bdb50b98e2e0dae0ce4e0146a branch November 16, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant