Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 404 response code check on delete call #3018

Conversation

modular-magician
Copy link
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container : fixed container cluster not removed from the state when received 404 error on delete call for the resource `google_container_clsuter`

fixes hashicorp/terraform-provider-google#8480

Derived from GoogleCloudPlatform/magic-modules#4512

* added 404 response code check on delete call

* log statement added and error check corrected

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Mar 2, 2021
@modular-magician modular-magician merged commit ef373f9 into hashicorp:master Mar 2, 2021
@modular-magician modular-magician deleted the downstream-pr-92c6dfc045196276fa917e5246acd705760f5d59 branch November 16, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant